Cleanup helm template since metrics path is not configurable#6444
Merged
Conversation
Collaborator
Code Review Agent Run Status
|
Sovietaced
added
the
housekeeping
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6444 +/- ##
=======================================
Coverage 58.48% 58.48%
=======================================
Files 940 940
Lines 71584 71584
=======================================
+ Hits 41866 41867 +1
+ Misses 26535 26534 -1
Partials 3183 3183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
Member
|
Hi @Sovietaced |
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Member
Author
Done |
machichima
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The metrics path is not configurable on the cluster resource manager so this simplifies the helm chart.
What changes were proposed in this pull request?
Remove the ability to configure the cluster resource manager metrics path since it is not effective.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Summary by Bito
This pull request simplifies the Helm chart for the cluster resource manager by removing ineffective metrics path configurations and replacing them with a static value. It also updates HA shared secret checksums across multiple manifest files for consistency, enhancing the clarity of the Helm templates.