Agent auto discovery conflicts with explicit task type mapping#6464
Merged
pingsutw merged 6 commits intoMay 28, 2025
Conversation
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6464 +/- ##
==========================================
+ Coverage 58.48% 58.51% +0.02%
==========================================
Files 940 940
Lines 71583 71582 -1
==========================================
+ Hits 41866 41885 +19
+ Misses 26534 26518 -16
+ Partials 3183 3179 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
Future-Outlier
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #6349
Why are the changes needed?
The current propeller agent/connector task_type auto-discovery in combination with ignoring the explicit mapping will cause problems while 2 agent/connector deployments has different config but has the same support task type. On the other hand, it also complicates agent development. Developers have to be mindful of which agents are installed on the image and cannot simply rely on the mapping in the configuration.
What changes were proposed in this pull request?
Respect the explicit task_type mapping over the implicit (auto-discovery) mapping. The agent/connector registry will always inline with the
agentForTaskTypessettings in the config file.How was this patch tested?
The unit test in this PR can test the expected behavior.
Labels
Please add one or more of the following labels to categorize your PR:
Check all the applicable boxes
Summary by Bito
This pull request enhances the agent and connector task type auto-discovery by prioritizing explicit task type mappings in the configuration over implicit ones. It modifies the registry handling to ensure configuration settings are respected and includes unit tests to validate these changes.