Skip to content

webhook with external service#6466

Closed
pingsutw wants to merge 1 commit into
masterfrom
webhook-external-service
Closed

webhook with external service#6466
pingsutw wants to merge 1 commit into
masterfrom
webhook-external-service

Conversation

@pingsutw

@pingsutw pingsutw commented May 23, 2025

Copy link
Copy Markdown
Member

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Summary by Bito

This pull request updates the Dockerfile and configuration YAML file, modifying the CMD instruction to include new server arguments for enhanced configuration. The serviceName in the YAML file has also been updated to better reflect its purpose, indicating a transition to a webhook service.

Signed-off-by: Kevin Su <pingsutw@apache.org>
@codecov

codecov Bot commented May 23, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.48%. Comparing base (5f98022) to head (f1e7c95).
⚠️ Report is 133 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6466      +/-   ##
==========================================
- Coverage   58.48%   58.48%   -0.01%     
==========================================
  Files         940      940              
  Lines       71584    71584              
==========================================
- Hits        41867    41866       -1     
- Misses      26534    26535       +1     
  Partials     3183     3183              
Flag Coverage Δ
unittests-datacatalog 59.03% <ø> (ø)
unittests-flyteadmin 56.26% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 64.72% <ø> (ø)
unittests-flyteidl 76.12% <ø> (ø)
unittests-flyteplugins 60.95% <ø> (ø)
unittests-flytepropeller 54.78% <ø> (ø)
unittests-flytestdlib 64.02% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pingsutw pingsutw marked this pull request as draft May 23, 2025 22:39
@github-actions github-actions Bot added the stale label Feb 18, 2026
@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown

"Hello 👋, this PR has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this PR as stale and will close the PR if we detect no activity in the next 14 days. Thank you for your contribution and understanding! 🙏"

@github-actions github-actions Bot closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant