Skip to content

Move whitelist configuration provider to mockery#6477

Merged
Sovietaced merged 1 commit into
flyteorg:masterfrom
Sovietaced:issue-149
Jun 5, 2025
Merged

Move whitelist configuration provider to mockery#6477
Sovietaced merged 1 commit into
flyteorg:masterfrom
Sovietaced:issue-149

Conversation

@Sovietaced

@Sovietaced Sovietaced commented May 30, 2025

Copy link
Copy Markdown
Member

Tracking issue

Related to #149

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Summary by Bito

This pull request refactors task validation tests and the task manager test configuration, enhancing reliability by utilizing mockery for the whitelist configuration provider. It improves error handling and updates mock configurations, streamlining testing and increasing code maintainability.

Signed-off-by: Jason Parraga <sovietaced@gmail.com>
@flyte-bot

Copy link
Copy Markdown
Collaborator

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at eduardo@union.ai.

@Sovietaced Sovietaced changed the title Move whitelist provider to mockery Move whitelist configuration provider to mockery May 30, 2025
@Sovietaced Sovietaced added the housekeeping Issues that help maintain flyte and keep it tech-debt free label May 30, 2025
@Sovietaced Sovietaced marked this pull request as ready for review May 30, 2025 02:10
@codecov

codecov Bot commented May 30, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.50%. Comparing base (aaf6fec) to head (3ff7346).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6477   +/-   ##
=======================================
  Coverage   58.50%   58.50%           
=======================================
  Files         940      940           
  Lines       71582    71582           
=======================================
+ Hits        41878    41881    +3     
+ Misses      26525    26521    -4     
- Partials     3179     3180    +1     
Flag Coverage Δ
unittests-datacatalog 59.03% <ø> (ø)
unittests-flyteadmin 56.25% <ø> (+0.01%) ⬆️
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 64.72% <ø> (ø)
unittests-flyteidl 76.12% <ø> (ø)
unittests-flyteplugins 61.08% <ø> (ø)
unittests-flytepropeller 54.78% <ø> (ø)
unittests-flytestdlib 64.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sovietaced Sovietaced requested a review from popojk June 4, 2025 16:28

@popojk popojk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@machichima machichima left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Sovietaced Sovietaced merged commit 171c777 into flyteorg:master Jun 5, 2025
49 checks passed
@Sovietaced Sovietaced deleted the issue-149 branch June 5, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Issues that help maintain flyte and keep it tech-debt free

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants