Common Filter to take in int values as well
#6742
Conversation
|
Bito Automatic Review Skipped - Branch Excluded |
|
|
||
| .PHONY: buf | ||
| buf: buf-dep buf-format buf-lint buf-rust buf-python buf-go buf-ts buf-ts-check | ||
| buf: buf-dep buf-format buf-lint buf-rust buf-python buf-go buf-ts buf-ts-check mocks |
There was a problem hiding this comment.
Adding mock generation to this command as mocks gets deleted when running this, so it should also regenerate it (otherwise people will have to run another command to unblock themselves with changes)
|
Bito Automatic Review Skipped - Branch Excluded |
| // ONLY ONE of the following value fields should be set. | ||
| // Only in the case of a VALUE_IN function, values may contain multiple entries. | ||
| repeated string values = 3; | ||
| repeated int32 int_values = 4; |
There was a problem hiding this comment.
You can make this a OneOf without breaking the wire format (You can even change the field name unless we are using json for requests).. Is the reason you are not so you don't break the code compilation?
There was a problem hiding this comment.
The main reason is we can't have
oneof values {
repeated string strings = 3;
repeated int32 ints = 4;
}
We'd have to wrap these lists in their own proto struct to get it to work :/
There was a problem hiding this comment.
aaah yes yes I hate that, yes :(
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link