Skip to content

Conversation

@BarryWu0812
Copy link

Tracking issue

Closes #6701

Why are the changes needed?

Add v2 flytecopilot plugin

What changes were proposed in this pull request?

How was this patch tested?

go build ./flytecopilot/...
make compile

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Barry Wu <[email protected]>
@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

@BarryWu0812 BarryWu0812 marked this pull request as draft November 21, 2025 23:37
@BarryWu0812 BarryWu0812 marked this pull request as ready for review November 22, 2025 05:45
@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

@machichima
Copy link
Member

I got following error when building. I think the flytecopilot/cmd is missing?

image

Copy link

@zabiclassy-debug zabiclassy-debug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got following error when building. I think the flytecopilot/cmd is missing?

image

@BarryWu0812
Copy link
Author

BarryWu0812 commented Nov 24, 2025

I got following error when building. I think the flytecopilot/cmd is missing?

image

I update the cmd folder, could you help me to try again? Thanks

@BarryWu0812 BarryWu0812 reopened this Nov 24, 2025
@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

@machichima
Copy link
Member

machichima commented Nov 24, 2025

It works now! Thanks! Please also do make gen and push the changes to resolve the CI error

A quick question: why we also need to move boilerplate/ here?

@machichima
Copy link
Member

I think we can also remove CODEOWNERS, CODE_OF_CONDUCT.md, and LICENSE under flytecopilot/ as we will have that in project root? cc @EngHabu to confirm

@BarryWu0812
Copy link
Author

CODEOWNERS, CODE_OF_CONDUCT.md, and LICENSE under flytecopilot/ as we will have that in project root? cc @EngHabu to confirm

Sure! I can further make a change after confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants