Update Flyte to Go 1.26#7240
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7240 +/- ##
=======================================
Coverage 56.95% 56.96%
=======================================
Files 931 931
Lines 58250 58247 -3
=======================================
+ Hits 33179 33180 +1
+ Misses 22017 22013 -4
Partials 3054 3054
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Sovietaced
commented
Apr 23, 2026
| return verifyClaims(sets.NewString(append(r.allowedAudience, expectedAudience)...), t.Claims.(jwtgo.MapClaims)) | ||
| } | ||
|
|
||
| func doRequest(ctx context.Context, req *http.Request) (*http.Response, error) { |
Member
Author
There was a problem hiding this comment.
This I unused and was causing a gosec warning so I removed it
Sovietaced
commented
Apr 23, 2026
| }) | ||
| } | ||
|
|
||
| func Test_doRequest(t *testing.T) { |
Member
Author
There was a problem hiding this comment.
Test of unused method
Sovietaced
commented
Apr 23, 2026
| secretsData := make(map[string][]byte, 4) | ||
|
|
||
| err := filepath.Walk(localPath, func(path string, info os.FileInfo, err error) error { | ||
| fsys := os.DirFS(localPath) |
Member
Author
There was a problem hiding this comment.
Resolves a gosec warning about walking a filesystem and having the files switch to symlink underneath.
Sovietaced
commented
Apr 23, 2026
| return func(writer http.ResponseWriter, request *http.Request) { | ||
| // 1. Limit the request body to 1MB (1 << 20 bytes) | ||
| // This MUST be done before ParseForm() or FormValue() | ||
| request.Body = http.MaxBytesReader(writer, request.Body, 1048576) |
Member
Author
There was a problem hiding this comment.
This resolve a gosec warning about resource exhaustion when using an unbuffered reader.
Sovietaced
added
housekeeping
nuthalapativarun
pushed a commit
to nuthalapativarun/flyte
that referenced
this pull request
May 1, 2026
Signed-off-by: Jason Parraga <sovietaced@gmail.com> Signed-off-by: Varun Nuthalapati <nuthalapativarun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pull request updates Flyte to use the latest version of Go. Consequently this also updates
golangci-lintwhich added the following new warnings.How was this patch tested?
Existing unit / integration tests
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link