Fix: return error when update affects zero rows in execution repo#7283
Fix: return error when update affects zero rows in execution repo#7283muskan-creates352 wants to merge 1 commit into
Conversation
9e0a919 to
2031b31
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7283 +/- ##
==========================================
+ Coverage 56.58% 58.53% +1.95%
==========================================
Files 931 703 -228
Lines 64866 41189 -23677
==========================================
- Hits 36707 24112 -12595
+ Misses 25105 14944 -10161
+ Partials 3054 2133 -921
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi , This PR ensures that update operations return an error when no rows are affected, preventing silent failures. The fix has been applied consistently across ExecutionRepo, TaskExecutionRepo, and NodeExecutionRepo. Please let me know if any further changes are needed. Thanks! |
c22101c to
8e655f3
Compare
|
Hi, Could you please approve the workflows so that the checks can run? Thanks! |
8e655f3 to
67563e0
Compare
Signed-off-by: Muskan Kumari <er.muskan09@gmail.com>
67563e0 to
a002f88
Compare
|
The issue you linked to references code in the v2 branch but you've fixed some unrelated code in the |
Fixes #7257
This PR ensures that Update operations in ExecutionRepo return an error when no rows are affected.
Previously, updates silently succeeded even if no matching record existed, which could lead to hidden data issues.
This change adds a check on RowsAffected and returns a not found error when no rows are updated.