Enable dot in config keys#7369
Merged
machichima merged 3 commits intoMay 15, 2026
Merged
Conversation
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
3 tasks
Contributor
|
Can't wait to have this released 🤗 |
Signed-off-by: machichima <nary12321@gmail.com>
pingsutw
approved these changes
May 14, 2026
davidmirror-ops
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #6166
Why are the changes needed?
We may want to set annotations with dots in keys (e.g.
cluster-autoscaler.kubernetes.io/safe-to-evict: "false"). Currently, when setting config like:We will get error:
The YAML is parsed as
{"default-annotations": {"test": {"annotation": "true"}}}instead of the intended{"default-annotations": {"test.annotation": "true"}}What changes were proposed in this pull request?
Adds a post-processing pass in
parseViperConfigthat re-reads the raw YAML config files and patches viper's output to restore any leaf keys that contained dots. This follows the same pattern as the existingrestoreCaseSensitiveArrayKeysworkaround in the file.How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Stack
If you do use
git townto manage PR Stacks, the stack relevant to this PRwill show below. Otherwise, you can ignore this section.
Docs link