Skip to content

[Helm] Update manager pod template configuration to align with deployment#7432

Merged
Sovietaced merged 1 commit into
flyteorg:masterfrom
Sovietaced:shard-improvements
May 28, 2026
Merged

[Helm] Update manager pod template configuration to align with deployment#7432
Sovietaced merged 1 commit into
flyteorg:masterfrom
Sovietaced:shard-improvements

Conversation

@Sovietaced

@Sovietaced Sovietaced commented May 28, 2026

Copy link
Copy Markdown
Member

Why are the changes needed?

This pull request brings the sharded flyte propeller user experience closer to the default, non-shareded flyte propeller one. It brings support for the following into the pod template:

  1. Custom pod environment variables (we use this to configure OTEL)
  2. Custom volumes / volume mounts (we use this for loading in root certificate)
  3. Prometheus scraping service discovery (we use this for observability)

What changes were proposed in this pull request?

How was this patch tested?

Tested in our production environment

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Stack

If you do use git town to manage PR Stacks, the stack relevant to this PR
will show below. Otherwise, you can ignore this section.

Docs link

Signed-off-by: Jason Parraga <sovietaced@gmail.com>
@github-actions github-actions Bot added the flyte label May 28, 2026
- name: auth
mountPath: /etc/secrets/
{{- end }}
- name: config-volume

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar indentation to how the deployment is...

@Sovietaced Sovietaced added helm changed For changes in existing functionality labels May 28, 2026
@Sovietaced Sovietaced marked this pull request as ready for review May 28, 2026 06:27
@Sovietaced Sovietaced changed the title [Helm] Update manager pod template to align with deployment [Helm] Update manager pod template configuration to align with deployment May 28, 2026
@Sovietaced Sovietaced enabled auto-merge (squash) May 28, 2026 16:49
@Sovietaced Sovietaced merged commit 5053471 into flyteorg:master May 28, 2026
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changed For changes in existing functionality flyte helm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants