You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I'm a developer working on JDBC and migration tooling at CUBRID. I would like to keep contributing to Flyway's CUBRID support, and this PR starts by adding integration test coverage for the CUBRID module.
This PR adds Testcontainers-backed integration tests for CUBRID community database support.
The tests cover the core Flyway workflows currently supported by the module:
migrate
validate
baseline
clean
Details
Uses the official cubrid/cubrid:11.4 image with the CUBRID JDBC driver.
Splits migration resources into initial and next locations to verify that Flyway applies only newly discovered migrations after existing migrations have already been applied.
Runs the tests with CUBRID's default non-DBA public user.
@ibi107
After removing the headers I ran the tests locally, and they were automatically added during the process-sources phase. The files affected were the test Java file and the three SQL migration files.
Here is the command I used:
sh ./mvnw -pl flyway-database-cubrid test
Is this the right command for this module, or would you recommend a different one? I want to make sure the PR stays clean. Thanks for taking a look.
@ibi107 After removing the headers I ran the tests locally, and they were automatically added during the process-sources phase. The files affected were the test Java file and the three SQL migration files.
Here is the command I used:
sh ./mvnw -pl flyway-database-cubrid test
Is this the right command for this module, or would you recommend a different one? I want to make sure the PR stays clean. Thanks for taking a look.
I think the license exclusion is declared incorrectly in the root pom, that's a separate issue however. PR looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi, I'm a developer working on JDBC and migration tooling at CUBRID. I would like to keep contributing to Flyway's CUBRID support, and this PR starts by adding integration test coverage for the CUBRID module.
This PR adds Testcontainers-backed integration tests for CUBRID community database support.
The tests cover the core Flyway workflows currently supported by the module:
Details
Validation
Tested locally with Java 21:
sh ./mvnw -pl flyway-database-cubrid testResult: