Skip to content

Add integration tests for CUBRID database support#128

Merged
ibi107 merged 3 commits into
flyway:mainfrom
Srltas:main
May 14, 2026
Merged

Add integration tests for CUBRID database support#128
ibi107 merged 3 commits into
flyway:mainfrom
Srltas:main

Conversation

@Srltas
Copy link
Copy Markdown
Contributor

@Srltas Srltas commented Apr 27, 2026

Summary

Hi, I'm a developer working on JDBC and migration tooling at CUBRID. I would like to keep contributing to Flyway's CUBRID support, and this PR starts by adding integration test coverage for the CUBRID module.

This PR adds Testcontainers-backed integration tests for CUBRID community database support.

The tests cover the core Flyway workflows currently supported by the module:

  • migrate
  • validate
  • baseline
  • clean

Details

  • Uses the official cubrid/cubrid:11.4 image with the CUBRID JDBC driver.
  • Splits migration resources into initial and next locations to verify that Flyway applies only newly discovered migrations after existing migrations have already been applied.
  • Runs the tests with CUBRID's default non-DBA public user.

Validation

Tested locally with Java 21:

sh ./mvnw -pl flyway-database-cubrid test

Result:

Tests run: 6, Failures: 0, Errors: 0, Skipped: 0
BUILD SUCCESS

@Srltas
Copy link
Copy Markdown
Contributor Author

Srltas commented May 14, 2026

@ibi107
After removing the headers I ran the tests locally, and they were automatically added during the process-sources phase. The files affected were the test Java file and the three SQL migration files.

Here is the command I used:

sh ./mvnw -pl flyway-database-cubrid test

Is this the right command for this module, or would you recommend a different one? I want to make sure the PR stays clean. Thanks for taking a look.

@ibi107
Copy link
Copy Markdown
Contributor

ibi107 commented May 14, 2026

@ibi107 After removing the headers I ran the tests locally, and they were automatically added during the process-sources phase. The files affected were the test Java file and the three SQL migration files.

Here is the command I used:

sh ./mvnw -pl flyway-database-cubrid test

Is this the right command for this module, or would you recommend a different one? I want to make sure the PR stays clean. Thanks for taking a look.

I think the license exclusion is declared incorrectly in the root pom, that's a separate issue however. PR looks good.

@ibi107 ibi107 merged commit 1b55efc into flyway:main May 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants