[CUBRID] Drop foreign keys before clean#136
Open
Srltas wants to merge 1 commit into
Open
Conversation
CUBRID prevents dropping tables referenced by foreign keys, causing Flyway clean to fail on schemas with parent/child relationships. This fix identifies referencing foreign keys via JDBC metadata and drops them first to ensure successful table deletion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flyway
cleanfails on CUBRID schemas containing tables linked by foreign keys. CUBRID prevents dropping a table that is still referenced by a foreign key from another table, so the currentCubridSchema.doClean()fails when a parent table is encountered before its referecing children, and cannot resolve circular foreign key references at all.This PR fixes ths issue by discovering incoming foreign keys via JDBC metadata and dropping those constraints before dropping the tables.
Details
CubridSchema.doClean()now callsdropForeignKeys()before iterating overdoAllTables().dropForeignKeys()queriesDatabaseMetaData.getImportedKeys()for each table in the schema and runsALTER TABLE ... DROP CONSTRAINTfor every incoming foreign key.DROP TABLEsequence succeeds regardless of order.cleanTablesWithForeignKeysintergration test that createsparent_tableandchild_tablelinked by a foreign key, then verifiesflyway.clean()removes both.Validation
Tested locally with Java 21:
sh ./mvnw -pl flyway-database-cubrid testResult: