chore(ver): Update OpenLiteSpeed to v1.8.3, feat: Add PHP 8.3 Support (Beta) #16
Conversation
|
@ma-04 we must have to keep the php-7.4 version. Please include the necessary steps to install PHP packages for ARM. |
WalkthroughThis pull request updates the GitHub Actions workflows and the OpenLiteSpeed Dockerfile. Both the deployment and test workflows have been modified to include PHP version 8.3 with a corresponding lsphp configuration, and the QEMU setup has been explicitly configured with a specific image version. Additionally, the OpenLiteSpeed Dockerfile is updated to use version 1.8.3 instead of 1.8.1. Changes
Sequence Diagram(s)sequenceDiagram
participant WA as GitHub Actions Workflow
participant QM as QEMU Setup Step
participant BM as Build Matrix Job
participant DF as Dockerfile Build
WA->>QM: Setup QEMU with tonistiigi/binfmt:qemu-v7.0.0-28
WA->>BM: Initiate build with PHP versions [7.4, 8.1, 8.2, 8.3]
BM->>DF: Build Docker image using OLS_VERSION=1.8.3
Possibly related PRs
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ma-04
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/test.yml (1)
17-17: Retaining PHP 7.4 in the Build Matrix
Although the PR title mentions the removal of PHP 7.4 support due to missing ARM packages, the build matrices for both PHP and OpenLiteSpeed jobs still include PHP 7.4. Please clarify whether PHP 7.4 should be retained or removed. If it is to be kept, consider documenting the necessary steps to handle ARM-specific package issues for PHP 7.4.Also applies to: 55-56
.github/workflows/deploy.yml (1)
20-21: PHP 7.4 Presence in Deployment Matrix
The deployment matrix for thebuild-phpjob (lines 20–21) still includes PHP 7.4, even though the PR title suggests removing it. Please confirm whether PHP 7.4 support should continue. If retained, consider including documentation or automated steps addressing the lack of ARM packages for PHP 7.4.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/deploy.yml(1 hunks).github/workflows/test.yml(2 hunks)openlitespeed/Dockerfile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: build-php (8.3)
- GitHub Check: build-php (8.1)
- GitHub Check: build-php (8.2)
- GitHub Check: build-php (7.4)
- GitHub Check: build-php (8.0)
🔇 Additional comments (5)
openlitespeed/Dockerfile (1)
7-7: OpenLiteSpeed Version Update
TheOLS_VERSIONargument is updated to1.8.3, which aligns with the PR’s objective of upgrading OpenLiteSpeed. Please verify that the download URL and installation commands (lines 26–29) are fully compatible with version 1.8.3..github/workflows/test.yml (2)
24-25: Explicit QEMU Setup in Build-php Job
The addition of thewithblock specifyingimage: tonistiigi/binfmt:qemu-v7.0.0-28ensures that the QEMU emulator is consistently configured across builds. This explicit configuration can help avoid issues on non-amd64 platforms.
61-62: Adding PHP 8.3 to the Build-openlitespeed Matrix
PHP 8.3 has been added to the build matrix (lines 61–62) for the OpenLiteSpeed job, which supports the new PHP beta release. Please ensure thorough testing for any beta-specific incompatibilities..github/workflows/deploy.yml (2)
74-83: Update of Build-openlitespeed Matrix to Include PHP 8.3
The build matrix for the OpenLiteSpeed deployment now includes the PHP 8.3 entry (lines 74–83) withlsphp: "lsphp83". This change is consistent with the testing workflow and supports the new PHP version.
90-91: Enhanced QEMU Configuration in Deployment Workflow
The QEMU setup step now explicitly specifies the imagetonistiigi/binfmt:qemu-v7.0.0-28(lines 90–91), which should help ensure consistent behavior across different target architectures.
|
LiteSpeed support has rebuild their arm packages for PHP 7.4 and currently includes all the necessary packages required by the dockerfiles. All builds are succeding without issue. But if we move from ubuntu:22.04 to ubuntu:24.04, then we might have to drop support for PHP 7.4/8.0 |
ma-04
changed the title
This pull request makes several updates to the project:
Update OpenLiteSpeed (OLS) Version:
Add PHP 8.3 Support (Beta):
### Remove PHP 7.4 Support:- Removed PHP 7.4 from the matrix strategy due to missing ARM packages. Specifically, packages like lsphp74-mysql, lsphp74-opcache, lsphp74-curl, lsphp74-intl, lsphp74-imap, and lsphp74-ldap are not available in the arm64 package list, although they are present in the amd64 package list.Binaries are also available but that would require manual installation.
Summary by CodeRabbit
New Features
Chores