Skip to content

Conversation

@fmasa
Copy link
Owner

@fmasa fmasa commented May 24, 2025

This PR fixes upload of desktop binaries and download page.

All the assets (binaries and metadata used by Conveyor) are uploaded to Github Release rather than to Github Pages and only the download page is now uploaded to Github Pages.

This is part of getting the desktop distribution to better shape:

  • it now actually works again
  • downloads from Releases seem to be faster than from Github Pages

@fmasa fmasa requested a review from Copilot May 24, 2025 16:43
@fmasa fmasa self-assigned this May 24, 2025
@fmasa fmasa added enhancement New feature or request Desktop labels May 24, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the upload of desktop binaries by switching asset uploads from GitHub Pages to GitHub Releases and adjusting the download page deployment.

  • Changed the Windows block in build configuration to update the upgrade UUID and remove the menu group setting.
  • Updated the repository URL in the conveyor configuration and removed the site configuration block.
  • Revised the GitHub Actions workflow to update action versions and streamline the packaging and deployment steps.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
desktop/build.gradle.kts Updated UUID in the Windows block and removed the menu group setting.
conveyor.conf Modified the vcs-url and removed the site configuration.
.github/workflows/desktop_distribution.yml Upgraded action versions, restructured artifact handling, and changed environment settings.
Comments suppressed due to low confidence (1)

.github/workflows/desktop_distribution.yml:38

  • The removal of the APP_VERSION environment variable might result in the build defaulting to '1.0.0', since it is used in build.gradle.kts. Please verify if this was intentional or consider reintroducing it with the proper value.
-      APP_VERSION: ${{ github.ref_name }}

@fmasa fmasa force-pushed the desktop-releases branch from 0ba54c6 to f5f8c17 Compare May 24, 2025 16:49
@fmasa fmasa requested a review from Copilot May 24, 2025 17:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to fix the upload process for desktop binaries and the download page by moving binary and metadata uploads to GitHub Releases, which improves download speeds and reliability.

  • Desktop installer configuration is updated (e.g., upgradeUuid change)
  • The download page setup through workflow and configuration has been modified
  • CI/CD workflow steps have been updated to newer actions versions and to separately handle asset uploads and Pages deployments

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
desktop/build.gradle.kts Updated Windows installer configuration by changing upgradeUuid and removing unused menuGroup.
conveyor.conf Removed the site block and modified vcs-url, which may affect URL resolution.
.github/workflows/desktop_distribution.yml Upgraded action versions and restructured steps to properly upload artifacts and deploy the download page.
Comments suppressed due to low confidence (1)

conveyor.conf:18

  • The vcs-url is missing the protocol (e.g., 'https://'). This may cause issues in systems expecting a fully qualified URL. Consider reverting to 'https://github.com/fmasa/wfrp-master' or ensuring that the URL is handled appropriately.
  vcs-url = "github.com/fmasa/wfrp-master"

@fmasa fmasa force-pushed the desktop-releases branch from f5f8c17 to d17c42d Compare May 24, 2025 18:20
@fmasa fmasa merged commit 0e6c2d0 into master May 24, 2025
9 checks passed
@fmasa fmasa deleted the desktop-releases branch May 25, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Desktop enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants