Replace Firebase Dynamic Links by Android App Links #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR migrates invitation links from Firebase Dynamic Links to native Android App Links and a custom URI scheme (wfrp-master://), removes the Dynamic Links dependency, and updates the web invitation page accordingly.
- Replace dynamic links with direct deep link strings in shared code
- Update Android manifest and assetlinks.json for App Links and custom protocol
- Revise web invitation page layout, QR code script, and styling
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| webapp/app/invitation.html | Updated invitation UI, added fallback open-app link and QR code |
| webapp/app.css | Added .text-center utility class |
| webapp/.well-known/assetlinks.json | Added assetlinks for App Links with placeholder package |
| gradle/libs.versions.toml | Removed Firebase Dynamic Links version entry |
| common/build.gradle.kts | Removed Firebase Dynamic Links implementation |
| common/src/androidMain/.../InvitationDialogContent.kt | Switched from Dynamic Links API to direct deepLink string |
| app/src/main/AndroidManifest.xml | Added autoVerify intent filter and custom scheme filter |
Comments suppressed due to low confidence (2)
webapp/app/invitation.html:38
- The QRCode initialization lacks a 'text' property, so no data will be encoded into the QR code. Consider adding a
textfield (e.g., the custom protocol link) to the options.
width: 200,
common/src/androidMain/kotlin/cz/frantisekmasa/wfrp_master/common/invitation/InvitationDialogContent.kt:71
- [nitpick] Consider adding unit tests for the
InvitationLinkScreen.deepLink(json)logic to ensure the generated deep link string matches the expected format.
val link = InvitationLinkScreen.deepLink(json).toString()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firebase Dynamic Links are deprecated and will shut down in August 2025.
This PR replaces these links with
dnd-master-58fca.web.applinks + custom protocolwfrp-master://which can in the future be used for Desktop apps as well. Since the domain is actually same as the domain that Dynamic links redirected to, the previously generatedwfrp.page.linklinks will continue to work until Firebase pulls the plug.In the future the plan is to use a shorter domain for the links instead of this automatically generated one but it's good enough for now and getting this out ASAP means that there will be fewer broken links out in the world.