Close popups by clicking buttons in modals #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JMatej
commented
May 10, 2022
JMatej
commented
- there are two new modals which we should close:
JMatej
commented
May 10, 2022
| await page.goto(url, wait_until="networkidle") | ||
|
|
||
| await page.click("#onetrust-accept-btn-handler") | ||
| await page.click(".closeButton") |
JMatej
changed the title
mrshu
reviewed
May 17, 2022
|
|
||
| await page.click("#onetrust-accept-btn-handler") | ||
| await page.click(".closeButton") | ||
| await page.click("#pendo-button-59b176ac") |
Contributor
There was a problem hiding this comment.
@JMatej Is this guaranteed to be there at all times? If so, this surely makes sense 🙂
mrshu
approved these changes
May 17, 2022
Contributor
|
@JMatej just one last comment -- please feel free to merge this in 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.