Simple average PSF - #68
Open
MaxusTheOne wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
It's not optional, but it should also be a seperate picture when downloading |
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces an average PSF calculation and integrates it as the first image in the PSF summary stack. Key changes include:
- Adding a new method get_averaged_bead in the analyzer to average bead data.
- Adding getter methods (get_date, get_version, get_dpi) for additional parameters.
- Modifying the measurement callback in the dock widget to include processing and concatenation of an averaged PSF image.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/napari_psf_analysis/psf_analysis/analyzer.py | Adds a method for averaging bead data and additional getters. |
| src/napari_psf_analysis/_dock_widget.py | Integrates the averaged PSF image into the measurement stack display. |
Comments suppressed due to low confidence (1)
src/napari_psf_analysis/psf_analysis/analyzer.py:57
- [nitpick] Consider revising informal language such as 'Rn' to 'Currently' for clarity in the TODO comment.
# TODO: Implement a filter so it does not crash. Rn the program would have crashed regardless
Comment on lines
+66
to
+67
|
|
||
|
|
There was a problem hiding this comment.
The exception handling in get_averaged_bead prints an error without returning a value, which may lead to issues downstream. Consider explicitly returning None or re-raising a custom exception for better error propagation.
Suggested change
| return None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an average PSF as the first image of a PSF summary stack
My version has it with a title. Once it is stable enough I will maybe open a big pull request