Skip to content

Plumb function context through to authorization service and therefore handlers. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Plumb function context through to authorization service and therefore handlers. #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dd74be9
Update README.md
MaxGuernseyIII Jul 20, 2023
18e3a04
Update AuthorizationFunctionMiddlewareShould.cs
MaxGuernseyIII Jul 20, 2023
9eb51d3
Update AuthorizeFilter.cs
MaxGuernseyIII Jul 20, 2023
7d4aff4
Update AuthorizationFunctionMiddleware.cs
MaxGuernseyIII Jul 20, 2023
be350df
Update README.md
MaxGuernseyIII Jul 20, 2023
28535fc
fix build
MaxGuernseyIII Jul 31, 2023
6a3e515
revert last change
MaxGuernseyIII Jul 31, 2023
8307a0b
manual merge
MaxGuernseyIII Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/AzureFunctions.Extensions.OpenIDConnect.InProcess/AuthorizeFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public override async Task OnExecutingAsync(FunctionExecutingContext executingCo

if (requirements != null)
{
var authorizationResult = await _authorizationService.AuthorizeAsync(httpContext.User, null, requirements);
var authorizationResult = await _authorizationService.AuthorizeAsync(httpContext.User, executingContext, requirements);
if (!authorizationResult.Succeeded)
{
await Forbidden(httpContext, authorizationResult.Failure, cancellationToken);
Expand All @@ -75,4 +75,4 @@ private async Task Forbidden(HttpContext httpContext, AuthorizationFailure failu
throw new UnauthorizedAccessException();
}
}
}
}
8 changes: 4 additions & 4 deletions ...unctions.Extensions.OpenIDConnect.Isolated.Tests/AuthorizationFunctionMiddlewareShould.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,11 @@ public async Task ReturnForbiddenWhenAuthorizationFailed()
.Returns(requirements);

var authorizationService = Substitute.For<IAuthorizationService>();
authorizationService.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), Arg.Any<object>(), requirements)
.Returns(AuthorizationResult.Failed());

var context = Substitute.For<FunctionContext>();

authorizationService.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), context, requirements)
.Returns(AuthorizationResult.Failed());

var functionContextAccessor = Substitute.For<IHttpFunctionContextAccessor>();
functionContextAccessor.GetHttpRequestDataAsync()
.Returns(ValueTask.FromResult(TestingHttpRequestData.For(context)));
Expand Down Expand Up @@ -143,4 +143,4 @@ private static BindingMetadata BuildHttpTriggerMetadata()
}


}
}
4 changes: 2 additions & 2 deletions src/AzureFunctions.Extensions.OpenIDConnect.Isolated/AuthorizationFunctionMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public async Task Invoke(FunctionContext executingContext, FunctionExecutionDele

if (requirements != null)
{
var authorizationResult = await _authorizationService.AuthorizeAsync(authenticationResult.User, null, requirements);
var authorizationResult = await _authorizationService.AuthorizeAsync(authenticationResult.User, executingContext, requirements);
if (!authorizationResult.Succeeded)
{
Forbidden(functionContextAccessor, requestData, authorizationResult.Failure);
Expand Down Expand Up @@ -87,4 +87,4 @@ private static void Forbidden(IHttpFunctionContextAccessor executingContext,
executingContext.SetInvocationResult(response);
}
}
}
}
2 changes: 1 addition & 1 deletion ...Extensions.OpenIDConnect.Isolated/AzureFunctions.Extensions.OpenIDConnect.Isolated.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\AzureFunctions.Extensions.OpenIDConnect\AzureFunctions.Extensions.OpenIDConnect.csproj" />
<ProjectReference Include="..\AzureFunctions.Extensions.OpenIDConnect\AzureFunctions.Extensions.OpenIDConnect.csproj" />
</ItemGroup>

</Project>