support podman auth json config #1613
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahjones
reviewed
May 8, 2025
api/agent/drivers/docker/registry.go
Outdated
| } | ||
| auths, err := docker.NewAuthConfigurations(strings.NewReader(authJson)) | ||
| if err != nil { | ||
| logrus.WithError(err).Infof("Failed to parse %s podman config. Fall back to docker config.", authJson) |
There was a problem hiding this comment.
Rather than log from here, return an error that can be logged at a higher level if necessary. It's not for this method to know that there will be a fallback to docker config, this method is just meant to get the config for Podman.
There was a problem hiding this comment.
Fixed. Could you please review again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Fn to support podman config location: /run/user//containers/auth.json.
In CloudShell OL8 environment, podman auth config is available but not docker config so this change is necessary so that CloudShell user does not need to set the FN_DOCKER_AUTH variable.
If the file is found, it will take precedence over the docker config. If it is not found or not valid, Fn will fallback to docker config.