Correct minitest loading in tests helper #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks like tests are still failing |
minitest must be loaded before mocha. Modern minitest also prefers explicit choosing of the test library instead of autodetection.
ekohl
force-pushed
the
correct-minitest-loading
branch
from
a20df43 to
cd4fde6
Compare
Contributor
Author
|
Ruby head is failing, but Ruby 3.2 would fail in exactly the same way. The gem just isn't compatible with it because |
stejskalleos
approved these changes
Jun 30, 2025
Collaborator
|
thanks @ekohl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minitest must be loaded before mocha. Modern minitest also prefers explicit choosing of the test library instead of autodetection.