Do not call t.Fatal() from non-main goroutines #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folbricht
reviewed
Dec 11, 2025
Calling t.Fatal() only stops the current goroutine, but not the rest. The result is different depending on a test, but in the worst case scenario (like an error in the server part of a test) the client may hang waiting indefinitely for the response, and the test ends with a panic from the test timeout, without showing the real reason for the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
t.Fatal()only stops the current goroutine, but not the rest. The result is different depending on a test, but in the worst case scenario (like an error in the server part of a test) the client may hang waiting indefinitely for the response, and the test ends with a panic from the test timeout, without showing the real reason for the issue.This PR makes errors during tests more obvious, showing problems with the test environment (e.g. missing /bin/fusermount or too restrictive sandbox).