Add PROXY protocol v1/v2 support for TCP-based listeners#512
Draft
Add PROXY protocol v1/v2 support for TCP-based listeners#512
Conversation
When routedns is deployed behind a load balancer (HAProxy, NGINX, cloud LBs), the real client IP is lost. This adds opt-in PROXY protocol support using github.com/pires/go-proxyproto, enabling listeners to parse PROXY protocol headers and use the real client IP throughout the pipeline. A new `proxy-protocol = true` config option can be set on any TCP-based listener (tcp, dot, doh, admin, odoh). The PROXY protocol header is parsed on the raw TCP connection before TLS, so the real client IP is available for logging, ACLs, routing, and all other pipeline components. Also fixes a pre-existing bug where ODoH listener was not passing ListenOptions through to its inner DoH listener. Closes #511
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tcp,dot,doh,admin,odoh) using go-proxyprotoproxy-protocol = trueis set on a listener, the real client IP from the PROXY header (sent by an upstream load balancer) is used throughout the pipeline — logging, ACLs, routing, and all other componentsListenOptions(includingnetns,fwmark,bind-if,allowed-net) through to its inner DoH listenerConfiguration
Closes #511