Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for generating human-readable labels for Title-like resources (Title/Variant/Parallel/Abbreviated) based on structured title properties in the resource doc, and refactors shared JSON-property extraction into a helper.
Changes:
- Introduces
TitleLabelGeneratorto build a label frommainTitle,subTitle,partNumber, andpartName. - Extracts reusable JSON
docproperty lookup intoLabelHelperand reuses it inHubLabelGenerator. - Registers the new generator in
LabelGeneratorServiceand adds unit tests covering spacing/missing-property behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/org/folio/ld/dictionary/label/TitleLabelGeneratorTest.java | Adds tests verifying title label composition and spacing behavior. |
| src/main/java/org/folio/ld/dictionary/label/generators/TitleLabelGenerator.java | Implements title label generation by joining available title properties. |
| src/main/java/org/folio/ld/dictionary/label/generators/HubLabelGenerator.java | Refactors property extraction to use the shared helper. |
| src/main/java/org/folio/ld/dictionary/label/LabelHelper.java | Adds shared helper for reading the first string value from a JSON doc property. |
| src/main/java/org/folio/ld/dictionary/label/LabelGeneratorService.java | Registers TitleLabelGenerator in the generator chain. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f408efd to
9aa5f36
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/test/java/org/folio/ld/dictionary/label/TitleLabelGeneratorTest.java
Show resolved
Hide resolved
src/test/java/org/folio/ld/dictionary/label/TitleLabelGeneratorTest.java
Outdated
Show resolved
Hide resolved
d3bb7c2 to
78ab575
Compare
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.



No description provided.