feat(cn-browse): Don't index instance ids for call numbers#919
Draft
viacheslavkol wants to merge 2 commits intomasterfrom
Draft
feat(cn-browse): Don't index instance ids for call numbers#919viacheslavkol wants to merge 2 commits intomasterfrom
viacheslavkol wants to merge 2 commits intomasterfrom
Conversation
- instead of aggregating all instance ids for call number from postgres - just count them and add instance id only if count=1 - Add count to call number index - Update browse service and search response post processor Implements: MSEARCH-1187
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
Don't index instance ids for call numbers
Same call number could be used in 20k, 40k and even 100k instances in production.
This results in retrieval of big aggreagates from postgres and then indexing all of it in elasticsearch.
However those ids aren’t really needed for anything. In case of multiple ids - we just return count in browse and in case of one id - we retrieve instance title by it.
Proposed approach will reduce memory pressure on mod-search, save space on elasticsearch and improve indexing and searching performance of call numbers
Approach
Changes Checklist
Related Issues
MSEARCH-1187