Skip to content

fix(aerc): make night theme diff colors more readable #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
calebdw wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(aerc): make night theme diff colors more readable #654

calebdw wants to merge 2 commits into from
+10 −10

Conversation

@calebdw
Copy link

@calebdw calebdw commented Oct 28, 2024

Description

Hello!

This closes #653 by making the diff more readable.

Screenshots

Before

image

After

image

Thanks!

@calebdw calebdw changed the title fix(aerc): make diff colors more readable fix(aerc): make night theme diff colors more readable Oct 28, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Nov 28, 2024
@calebdw
Copy link
Author

calebdw commented Nov 28, 2024

@folke, can this be merged? Thanks!

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label Nov 29, 2024
@folke
Copy link
Owner

folke commented Dec 15, 2024

extras are auto-generated, so I can't merge this.
You need to update the templates instead.

@calebdw
Copy link
Author

calebdw commented Dec 17, 2024

Ah, I see now---I've update the template and here's how the diff now looks:

image

@calebdw
Copy link
Author

calebdw commented Jan 2, 2025

@folke, just pinging you about the update, thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2025

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Feb 2, 2025
@calebdw
Copy link
Author

calebdw commented Feb 2, 2025

@folke, does this look good?

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label Feb 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Mar 5, 2025
@calebdw
Copy link
Author

calebdw commented Mar 5, 2025

@folke, just pinging again so the bot won't mark as stale

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label Mar 6, 2025
@archcorsair
Copy link
Contributor

archcorsair commented Mar 17, 2025

You shouldn't commit the generated ini files since they will get generated during CI. I made the same mistake earlier.

@calebdw
Copy link
Author

calebdw commented Mar 17, 2025

Thanks for the heads up, but it shouldn't matter because CI will just see that there's no changes

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Apr 17, 2025
@calebdw
Copy link
Author

calebdw commented Apr 17, 2025

@folke, just pinging again so the bot won't mark as stale

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label Apr 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2025

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label May 18, 2025
@calebdw
Copy link
Author

calebdw commented May 18, 2025

@folke, just pinging again so the bot won't mark as stale

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label May 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2025

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Jun 19, 2025
@calebdw
Copy link
Author

calebdw commented Jun 19, 2025

@folke, just pinging again so the bot won't mark as stale

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label Jun 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2025

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Jul 30, 2025
@calebdw
Copy link
Author

calebdw commented Jul 30, 2025

Just pinging so bot won't mark as stale

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label Jul 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2025

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Aug 31, 2025
@calebdw
Copy link
Author

calebdw commented Aug 31, 2025

Just pinging so bot won't mark as stale

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label Sep 1, 2025
@folke folke added the size/m Medium PR (<50 lines changed) label Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

extras size/m Medium PR (<50 lines changed)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: aerc code diff is too hard to see when using night theme

3 participants

@calebdw @folke @archcorsair