Skip to content

Conversation

@lubber-de
Copy link
Member

Description

  • Exclusive accordions only triggered the callback for the opening according but not for all the closing ones.
  • Also added the ability to cancel any open/close by returning false from the onOpening/onclosing/onChanging callbacks

Testcase

https://jsfiddle.net/lubber/dmqpnLtu/9/

Closes

#2826

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug type/feat Any feature requests or improvements state/awaiting-reviews Pull requests which are waiting for reviews javascript labels Aug 19, 2023
@lubber-de lubber-de added this to the 2.9.3 milestone Aug 19, 2023
@lubber-de lubber-de added the state/awaiting-docs Pull requests which need doc changes/additions label Aug 19, 2023
Copy link
Member

@ko2in ko2in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't closeOthers reflect the onClosing callback? What if I want to keep opening the accordion item that was already opened? Now, it only listens to the accordion that triggered the click event.

@lubber-de
Copy link
Member Author

I put this on hold for now, as, after some investigation, the current logic would need more refactoring to support that properly and be consistent as "closeothers" behaves differently than just closing the active accordion.

@lubber-de lubber-de added state/on-hold Issues and pull requests which are on hold for any reason and removed state/awaiting-reviews Pull requests which are waiting for reviews labels Sep 1, 2023
@lubber-de lubber-de modified the milestones: 2.9.3, 2.9.x Sep 1, 2023
@lubber-de lubber-de marked this pull request as draft September 1, 2023 21:20
@lubber-de lubber-de modified the milestones: 2.9.x, 2.10.x Feb 19, 2025
@lubber-de lubber-de added lang/javascript Anything involving JavaScript and removed javascript labels Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang/javascript Anything involving JavaScript state/awaiting-docs Pull requests which need doc changes/additions state/on-hold Issues and pull requests which are on hold for any reason type/bug Any issue which is a bug or PR which fixes a bug type/feat Any feature requests or improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants