-
-
Notifications
You must be signed in to change notification settings - Fork 336
feat(dropdown): allow editing of added items #3247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BrianJavier99
wants to merge
13
commits into
fomantic:develop
Choose a base branch
from
BrianJavier99:feat_fomantic_3232
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@BrianJavier99 Looks great 👍 I think it's more effective to bind the escape key for canceling edits. And, the text box design could use a minor tweak; perhaps we could remove the background and padding from the container. This way, leaving the text box by itself would improve both spacing and the editing experience. 🤔
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
state/awaiting-reviews
Pull requests which are waiting for reviews
type/feat
Any feature requests or improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
I have added a functionality that allows direct editing of the labels by clicking them when
allowAdditionsis set to true.The expected behavior is as follows:
allowAdditionsis set to true.DelandBackspacekeys are also ignored to prevent accidental deletion of the item.Enterkey.Enterkey would only save the changes made to the existing item.Testcase
https://jsfiddle.net/ReiVanBjair/a37v91gb/15/
Screenshot (if possible)
Closes
#3232