Various small fixes#431
Merged
Merged
Conversation
InstanceBuilder::set_maximum_distance_2_cuts existed (and the CSV parameters loader already recognized max2cut/max2Cut/maximum_distance_2_cuts) but main.cpp never wired a --max2cut/--maximum-distance-2-cuts flag to it, unlike its min2cut counterpart, so the parameter was unreachable from the command line.
…rameters Replace the plain automatic_stop bool with an optimization_mode field, matching every other OptimizeParameters-family struct in the codebase. optimize_column_generation_strips now passes the outer optimization_mode straight through instead of first collapsing it into a bool. The one place that still needs a plain bool (the external columngenerationsolver::LimitedDiscrepancySearchParameters) derives it from optimization_mode != Anytime. The recursive pricing sub-call in generate_lower_stage_patterns now explicitly requests NotAnytimeSequential (an internal sub-step, not a top-level search) instead of unconditionally setting automatic_stop = true.
In print_header(), the OpenDimensionX/OpenDimensionY cases paired the
single-letter "X"/"Y" headers with a 5-dash underline ("-----") instead of
a single dash, unlike every other column where the underline length
matches its header text. Affects rectangleguillotine, rectangle,
irregular and boxstacks (box already had it right; onedimensional doesn't
have this objective).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.