Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationale and proposal fields are not optional #5

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

felipesanches
Copy link
Contributor

No description provided.

@simoncozens
Copy link
Collaborator

I love this for rationale (and I love how the type system can enforce this for us), but private profile checks might not have public proposal URLs...

@felipesanches
Copy link
Contributor Author

but private profile checks might not have public proposal URLs...

I believe that mandatory rationale and proposal fields are part of the project's culture. If there's going to be any burden, it should be on those who do not yet follow that policy of documenting the font problems.

They should at least have private URLs (or other kinds of identifiers, perhaps to a private issue tracker, or any other tool used to track proposals).

In the worse case, it could state proposal="private" or proposal="unknown" and that would be a recurring reminder that they should be documenting these things, even when working in a private profile.

@simoncozens simoncozens merged commit ee113d9 into fonttools:main Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants