-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct and add missing NL translations #1080
base: master
Are you sure you want to change the base?
Conversation
@wvengen As a first attempt to contribute, I have updated the NL.yml translation as I noticed those missing entries. Didn't create an issue for it, though. Should I? |
Thanks, PR looks fine. But there is an open discussion whether to accept translations here or in Crowdin. See also the wiki on Translation. I think it would be helpful to do a Crowdin sync (pull translations), review, commit, and then merge this one, so that all the work there is not lost (though maybe just merging this is fine - I'm not fully sure though). |
Ah.. OK. Will check that. Better not to upset the workflow 😁 |
@wvengen As a follow-up: needed to dig a bit 😁 (will make some notes on that for newbies) but have CrowdIn installed and working locally. I do not have permissions, though, to download the current state from CrowdIn so preparing a PR from that is also not possible. |
Syncing Crowdin translations is something the maintainers need to do, so that is up to the development team. |
As, based on recent discussions, CrowdIn is currently not the decided way to handle translations, I have reopened this PR to correct some of the Dutch translations. |
59af04b
to
2e0e936
Compare
Minor typo corrected
Added missing entries for NL