Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct and add missing NL translations #1080

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RayOei
Copy link

@RayOei RayOei commented Jan 10, 2025

Minor typo corrected
Added missing entries for NL

@RayOei RayOei marked this pull request as ready for review January 10, 2025 12:45
@RayOei
Copy link
Author

RayOei commented Jan 10, 2025

@wvengen As a first attempt to contribute, I have updated the NL.yml translation as I noticed those missing entries. Didn't create an issue for it, though. Should I?

@wvengen
Copy link
Member

wvengen commented Jan 10, 2025

Thanks, PR looks fine. But there is an open discussion whether to accept translations here or in Crowdin. See also the wiki on Translation.

I think it would be helpful to do a Crowdin sync (pull translations), review, commit, and then merge this one, so that all the work there is not lost (though maybe just merging this is fine - I'm not fully sure though).

@RayOei
Copy link
Author

RayOei commented Jan 10, 2025

Ah.. OK. Will check that. Better not to upset the workflow 😁

@RayOei RayOei closed this Jan 10, 2025
@RayOei
Copy link
Author

RayOei commented Jan 12, 2025

@wvengen As a follow-up: needed to dig a bit 😁 (will make some notes on that for newbies) but have CrowdIn installed and working locally. I do not have permissions, though, to download the current state from CrowdIn so preparing a PR from that is also not possible.
I assume uploading is also not allowed but I added my translations directly in CrowdIn.

@wvengen
Copy link
Member

wvengen commented Jan 13, 2025

Syncing Crowdin translations is something the maintainers need to do, so that is up to the development team.

@RayOei
Copy link
Author

RayOei commented Feb 27, 2025

As, based on recent discussions, CrowdIn is currently not the decided way to handle translations, I have reopened this PR to correct some of the Dutch translations.

@RayOei RayOei reopened this Feb 27, 2025
@RayOei RayOei force-pushed the fix_nl_translations branch from 59af04b to 2e0e936 Compare March 11, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants