-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transport cost related issues #1082
base: master
Are you sure you want to change the base?
Fix transport cost related issues #1082
Conversation
4205ae6
to
d843be7
Compare
- Include transport costs when calculating the group sum of an order - When creating a foodcoop transaction, use the exact inverted sum of the group transactions to prevent rounding issues - Display transport costs above "The following were not ordered" to avoid confusion
d843be7
to
5f03182
Compare
Is this the PR which (also) solves all failing tests on recent PR's? |
No, that has been fixed by c7fc475. This is just the PR where I noticed it. I subsequently reported it and rebased this PR after it was fixed. |
Ah... thanks! Never mind... it helps when you pull from the correct repo. I thought I was on the latest master but I was not in the correct local repo which wasn't updated/synced... 😊 |
I'd rather wait for #1073 to be merged (since this is bound to happen any minute now :) ) and then review the rebased version of your PR. Sorry for not reviewing/merging it earlier though, I've missed the GitHub notification. Is that okay for you, @twothreenine, or do you think this to be something very urgent that needs to be in the upcoming 4.9.x release? (Is it an old bug or something new?) |
While it isn't fixed, unbalanced financial links will be created when there are transport costs (with the feature I introduced in #1064). The UI issues are old. So nothing critical, but a bit annoying. |
Bug: When creating a foodcoop transaction + finance link when settling an order, the group sum without transport costs was used for the foodcoop transaction, so whenever transport costs were involved, unbalanced finance links were created.
This commit changes:
This value is displayed (among other places) in the balancing summary box. I chose not to include transport costs in
groups_without_markup
though, since that would be more complicated and also because transport costs are some kind of "extra costs."The following were not ordered
to avoid confusion.Resolved by c7fc475: checks fail
The checks fail with the following note -- I didn't run them locally, so I don't know whether they'll pass.