-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On #736: Added cleanup migrations #762
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THX, first check LGTM. i'll give it a deep check in the next days and try it on some database to check if there are issues
db/migrate/20200718074330_delete_orphaned_records_from_all_tables.rb
Outdated
Show resolved
Hide resolved
ca76347
to
c6250de
Compare
(squashed and modified commits from issue_736)
989f32f
to
da9602e
Compare
I just fixed the unit tests by creating temporary tables for The cleanest overall solution (apart from test refactoring) would be to use an API for this kind of import/export (or at least some sort of shared schema via a gem), but that's outside of the scope of this PR. |
What is the intent here as is still in |
I'm not sure, what you're asking...
|
(squashed and modified commits from issue_736)