Add mcpclient for evaluation sub package to call the mobile-web mcp tool #20
Merged
Conversation
ben-zhang-at-salesforce
commented
Jul 2, 2025
ben-zhang-at-salesforce
commented
Contributor
- created mcpclient in evaluatoin sub package to call in the mobile-web mcp tool by name.
- added tests to verify the mcpclient call to the 11 tools returns correct result.
ben-zhang-at-salesforce
force-pushed
the
mcpclient
branch
4 times, most recently
from
aec12e5 to
3ae840d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 90.83% 91.20% +0.37%
==========================================
Files 21 22 +1
Lines 698 728 +30
Branches 92 98 +6
==========================================
+ Hits 634 664 +30
Misses 64 64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| method: no | ||
| macro: no | ||
|
|
||
| macro: no |
Contributor
Author
There was a problem hiding this comment.
my bad, duplicated the macro: in my pr. correct my mistake
| node-version: ${{ matrix.node }} | ||
| cache: 'npm' | ||
| - run: npm install | ||
| - run: npm run build:all |
Contributor
Author
There was a problem hiding this comment.
need npm build so the mcp server tool js could be launched.
| flags: mobile-web | ||
| name: mobile-web-coverage | ||
|
|
||
| - name: Upload evaluation coverage |
Contributor
Author
There was a problem hiding this comment.
upload the test coverage for evaluation
ben-zhang-at-salesforce
force-pushed
the
mcpclient
branch
from
3ae840d to
d9a6f2b
Compare
haifeng-li-at-salesforce
approved these changes
Jul 3, 2025
haifeng-li-at-salesforce
left a comment
haifeng-li-at-salesforce
left a comment
Contributor
There was a problem hiding this comment.
Ben walked me through the PR. The improvement looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.