fix: [W-20111990] fix getting connection to target-org #6633
+149
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: fix debugger tests refactor: extract target-org resolution to method with error handling - Extract target-org resolution logic into getTargetOrgConnection() method - Method throws errors with appropriate messages for early exit - Add try-catch around Org.create() to prevent unhandled exceptions - Add test stubs for Org.create() to fix unhandled promise rejections - Improve error handling consistency with early returns
peternhale
requested review from
RitamAgrawal and
daphne-sfdc
and removed request for
RitamAgrawal
mshanemc
reviewed
Nov 5, 2025
daphne-sfdc
reviewed
Nov 6, 2025
daphne-sfdc
approved these changes
Nov 6, 2025
There was a problem hiding this comment.
Tested using the following steps: ✅
- Create a scratch org using the PBO org as the dev hub and set the "Debug Apex" permission according to these instructions: https://developer.salesforce.com/docs/platform/sfvscode-extensions/guide/interactive-debugger.html
- Set breakpoints in FileUtilities.cls of dreamhouse-lwc
- Add the "Launch Apex Debugger" launch configuration to launch.json
- Click the green play button to launch the Apex Interactive Debugger
- Open Developer Console in the scratch org
- Run FileUtilitiesTest.cls from Developer Console
- Make sure the breakpoints set in Step 2 are stopped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes target-org resolution in the Apex debugger and resolves test failures related to unhandled promise rejections.
Changes
getTargetOrgConnection()method inapexDebug.tsand made it public for testabilitylaunchRequestto use early returns instead of throwing errors for expected conditionssendEventcalls witherrorToDebugConsolefor pre-connection errorsConfigAggregator.create()andOrg.create()with validtarget-orgvaluesgetTargetOrgConnection()inapexDebugForTestfor testingOrgDisplaystub from testsTesting
All 211 tests passing with no unhandled promise rejections.
@W-20111990@ #6558