test: e2e playwright on windows W-20153124 #6637
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove ./ prefix from screenshot paths to fix windows path doubling
- use {platform} in snapshotPathTemplate for platform-specific snapshots
- rename desktop-electron snapshots to desktop-darwin
- add VSCODE_DESKTOP=1 to test:desktop:ci script
- add iteration script for ci debugging
- create desktop-win32 snapshots with Ctrl+F4 keyboard shortcut - create desktop-linux snapshots with Ctrl+F4 keyboard shortcut - these platform-specific snapshots enable tests to pass on all platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
os-specific snapshots because of differeing shortcut keys (that sucks, I might consider doing this in an an assertion-based way instead of aria-snapshots in the next round of e2e tests).
playwright e2e for windows
What issues does this PR fix or reference?
#, @W-20153124@
proof that it runs (took a few tries, ai is good at this)
https://github.com/forcedotcom/salesforcedx-vscode/actions/runs/19152212788 (on the test-results for windows you can open the videos from the 5 tests)