refactor(soql): query plan always uses REST, no API prompt W-20246881#7018
Merged
Conversation
mshanemc
changed the base branch from
develop
to
daphne/W-20246881-query-planner
mshanemc
commented
Mar 19, 2026
| */ | ||
| const runSoqlQuery = async (connection: Connection, query: string, useTooling = false): Promise<QueryResult> => { | ||
| channelService.appendLine(nls.localize('data_query_running_query')); | ||
| channelService.appendLine( |
Contributor
Author
There was a problem hiding this comment.
I changed the channel logs just to make sure these worked. It's not important to keep them if you don't want to.
mshanemc
commented
Mar 19, 2026
| import * as vscode from 'vscode'; | ||
| import { Utils } from 'vscode-uri'; | ||
| import { channelService } from './services/channel'; | ||
|
|
mshanemc
commented
Mar 19, 2026
| @@ -9,42 +9,6 @@ jest.mock('../../../src/services/channel', () => ({ | |||
| channelService: { appendLine: jest.fn() }, | |||
| OUTPUT_CHANNEL: {} | |||
| })); | |||
Contributor
Author
There was a problem hiding this comment.
seems silly to mock i18n
daphne-sfdc
approved these changes
Mar 19, 2026
Contributor
There was a problem hiding this comment.
These query plan commands work with both sObjects that were supposed to be REST API and sObjects that were supposed to be Tooling API.
- SFDX: Get SOQL Query Plan with Currently Selected Text ✅
- "Get Query Plan" code lens ✅
- SFDX: Get SOQL Query Plan with Current File ✅
Executing SOQL queries:
- SFDX: Execute SOQL Query with Currently Selected Text ✅
- SFDX: Execute SOQL Query... ✅
daphne-sfdc
merged commit 6901037
into
daphne/W-20246881-query-planner
61 of 70 checks passed
daphne-sfdc
added a commit
that referenced
this pull request
Mar 20, 2026
…xt Editor View) (#7013) * feat: new command that calls REST and Tooling APIs to get Query Plan data and print it into Output Tab * feat: code lens + new "SFDX: Get SOQL Query Plan with Current File" command in commmand palette * feat: format the Query Plan results in table format like Developer Console * refactor(soql): query plan always uses REST, no API prompt W-20246881 (#7018) * refactor: api doesn't matter for queryPlan * fix: query plan doesn't allow you to type a query in an input box --------- Co-authored-by: Daphne Yang <daphne.yang@salesforce.com> * Merge branch 'develop' into daphne/W-20246881-query-planner --------- Co-authored-by: Shane McLaughlin <shane.mclaughlin@salesforce.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
@W-20246881@
Made with Cursor