refactor(services): eliminate PubSub waste from file watchers - W-22143377#7224
Open
peternhale wants to merge 1 commit intodevelopfrom
Open
refactor(services): eliminate PubSub waste from file watchers - W-22143377#7224peternhale wants to merge 1 commit intodevelopfrom
peternhale wants to merge 1 commit intodevelopfrom
Conversation
…43377 Replace centralized PubSub file/settings watchers with scoped, per-consumer watchers. Eliminates ~45K wasted events and ~15-17 redundant getStatus calls during npm install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replace centralized PubSub file/settings watchers with scoped, per-consumer watchers:
RelativePattern, filter with.forceignore, add callback-level debounce and in-flight cancellation ({ switch: true }). Eliminates ~45K wasted events and ~15-17 redundantgetStatuscalls duringnpm install.createFileSystemWatcherscoped to.sfdx/.sfpaths instead of subscribing to global PubSub.**/lwc/**/*.{js,ts,html,js-meta.xml},**/.sfdx/tools/testresults/apex/*.json).onDidChangeConfigurationwith pre-filtered callbacks instead of globalSettingsChangePubSub.fileChangePubSub,fileWatcherService,settingsChangePubSub,settingsWatcherServiceand their exports.What issues does this PR fix or reference?
@W-22143377@
Functionality Before
Global
**/*file watcher fires ~45K events duringnpm install, each pushed through Effect PubSub, producing ~15-17 redundantgetStatuscalls.Functionality After
Zero
getStatuscalls from file watcher duringnpm install. Only the 60s poll stream triggers status checks, which is the intended behavior.