ci(e2e): desktop E2E uses VSIX via E2E_FROM_VSIX opt-in; phase 1 org-browser - W-21432332#7254
Open
ci(e2e): desktop E2E uses VSIX via E2E_FROM_VSIX opt-in; phase 1 org-browser - W-21432332#7254
Conversation
…- W-21432332
- createDesktopTest: add useVsix option (defaults to E2E_FROM_VSIX=1 env var)
- new installedExtensionsDir worker fixture: hash-keyed VSIX cache under
.vscode-test/ext-<hash>/; installs via resolveCliArgsFromVSCodeExecutablePath
+ spawnSync; atomic rename; idempotent across parallel workers
- electronApp: VSIX mode uses --extensions-dir (installed cache), no
--extensionDevelopmentPath; dev-path mode unchanged
- org-browser: test:desktop deps use vscode:package (self + services) instead
of vscode:bundle so CI exercises real shipping artifact
- orgBrowserE2E.yml: add E2E_FROM_VSIX=1 to e2e-desktop job env
- disable all other E2E workflows + testCommitExceptMain for this branch
Made-with: Cursor
… - W-21432332 Use per-pid tmp directories during VSIX install so parallel Playwright workers don't conflict on the VS Code CLI's internal atomic rename step. Switch to resolveCliPathFromVSCodeExecutablePath (no baseArgs) to avoid duplicate --extensions-dir/--user-data-dir flag warnings. Made-with: Cursor
Made-with: Cursor # Conflicts: # .github/workflows/orgBrowserE2E.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an opt-in VSIX-based mode for desktop E2E tests. Previously, desktop tests launched VS Code via
--extensionDevelopmentPath, which loads the rawtscoutput (out/src) — not the bundleddist/artifact that ships to customers. WithE2E_FROM_VSIX=1, the test fixture builds a real VSIX withvscode:package, installs it into a hash-keyed cache dir under.vscode-test/ext-<hash>/, and launches VS Code with--extensions-dirinstead of--extensionDevelopmentPath. Dev-path remains the default for fast local iteration.Phase 1 (this PR): org-browser proven locally (macOS) and on CI (macOS, Windows, Ubuntu). Other packages follow in subsequent commits on this branch.
Key implementation details:
createDesktopTest.ts: newuseVsixoption (default:process.env.E2E_FROM_VSIX === '1'); newinstalledExtensionsDirworker fixture with per-pid temp dirs to prevent concurrent worker install conflictssalesforcedx-vscode-org-browser:test:desktopwireit deps switch fromvscode:bundle→vscode:packagefor self and servicesorgBrowserE2E.yml:E2E_FROM_VSIX: 1added toe2e-desktopjob envtest:desktopwireit scripts haveE2E_FROM_VSIXmarkedexternalso cache keys are mode-awareWhat issues does this PR fix or reference?
@W-21432332@
Functionality Before
Desktop E2E loads unbundled
out/srctsc output via--extensionDevelopmentPath. Packaging bugs (wrongdist/paths,.vscodeignoregaps,packageUpdatesnot applied) are invisible to tests.Functionality After
CI runs desktop E2E against the real VSIX (
dist/asmain, all packaging transforms applied). Local dev unchanged by default;E2E_FROM_VSIX=1opts in locally.Made with Cursor