feat(services): add PlainServicesApi facade - W-22419571#7309
Open
peternhale wants to merge 1 commit into
Open
feat(services): add PlainServicesApi facade - W-22419571#7309peternhale wants to merge 1 commit into
peternhale wants to merge 1 commit into
Conversation
External consumers must currently depend on effect and learn Effect-TS patterns just to call getConnection(). This adds a PlainServicesApi that wraps all services as Promise-returning methods plus vscode.Event<T> for reactive state, eliminating the framework dependency for consumers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlainServicesApifacade tosalesforcedx-vscode-servicesthat allows external consumers to use all services without importing or depending oneffectvscode.Event<T>patternsservicesproperty remains unchanged (non-breaking addition)salesforcedx-vscode-servicesandsalesforcedx-vscode-services-typesto document the new plain API as the recommended consumption patternTest plan
api.getConnection()without anyeffectimports@W-22419571@
🤖 Generated with Claude Code