Skip to content

fix: trim filenames when syncing React samples from npm @W-21361802@ - #61

Closed
k-j-kim wants to merge 2 commits into
forcedotcom:mainfrom
k-j-kim:fix/sync-trim-filenames
Closed

fix: trim filenames when syncing React samples from npm @W-21361802@#61
k-j-kim wants to merge 2 commits into
forcedotcom:mainfrom
k-j-kim:fix/sync-trim-filenames

Conversation

@k-j-kim

@k-j-kim k-j-kim commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

References: Contributing guide · Skill authoring guide · Agent Skills spec

What changed

  • Sanitize directory/file names (trim) during copyRecursive in both
    sync-react-b2e-sample.js and sync-react-b2x-sample.js so source
    paths with trailing spaces (e.g. from npm packages) are written
    without trailing spaces under samples/.
  • Fixes synced sample file rename: lds-guide-graphql.md (trailing space)
    -> lds-guide-graphql.md.

Why

Notes

@W-21361802@


Skills

Manual checklist

Description quality

  • Describes what the skill does and the expected output
  • Includes relevant Salesforce domain keywords (Apex, LWC, SOQL, metadata types, etc.)
  • Trigger phrases are specific enough for Vibes to select this skill reliably

Instructions

  • Clear goal statement
  • Step-by-step workflow
  • Validation rules for generated output
  • Defined output / artifact

Context efficiency

  • Core instructions are concise — supporting material lives in templates/, examples/, or docs/ subdirectories
  • No unnecessary background explanation in the body

Automated checks

Enforced by CI (npm run validate:skills) per the Agent Skills spec:

  • Directory is one level deep, named in kebab-case (max 64 chars), contains SKILL.md
  • Frontmatter name matches directory name; description is present, ≥ 20 words, ≤ 1024 characters, and includes trigger language
  • Body is non-empty and under 500 lines
  • Name uses gerund form ⚠ (warning — does not block merge)

- Sanitize directory/file names (trim) during copyRecursive in both
  sync-react-b2e-sample.js and sync-react-b2x-sample.js so source
  paths with trailing spaces (e.g. from npm packages) are written
  without trailing spaces under samples/.
- Fixes synced sample file rename: lds-guide-graphql.md (trailing space)
  -> lds-guide-graphql.md.

Made-with: Cursor
@k-j-kim k-j-kim changed the title fix: trim filenames when syncing React samples from npm fix: trim filenames when syncing React samples from npm @W-21361802@ Mar 17, 2026
@k-j-kim k-j-kim closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants