Fix compatibility with pygfx - #130
Merged
Merged
Conversation
This change prevents reactivity on custom dict subclasses and instead will check that only real dicts are converted into reactive proxies. The problem is that pygfx's geometry is a dict subclass and turning it into a reactive proxy will stop it from being recognized as a Geometry type, so pygfx will not accept it when you try to set the geometry attribute on a Mesh. I could check for pygfx specifically, but it seems to me that more problems are to be expected in the future if observ tries to proxy custom dict subclasses. I'm thinking to update list and set proxy as well.
Korijn
reviewed
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents reactivity on custom dict subclasses and instead will check that only 'real' (or pure) dicts are converted into reactive proxies.
The problem is that pygfx's geometry is a dict subclass and turning it into a reactive proxy will stop it from being recognized as a Geometry type, so pygfx will not accept it when you try to set the geometry attribute on a Mesh.
I could check for pygfx specifically, but it seems to me that more problems are to be expected in the future if observ tries to proxy custom dict subclasses.
I'm thinking to update list and set proxy as well.
A workaround in Collagraph is to check for the
__target__attribute when setting the attribute, but I guess that this change also prevents any computational overhead from creating unnecessary proxies of dict subclasses.