Skip to content

Convert recursive method into iterative to prevent function calls - #143

Merged
berendkleinhaneveld merged 1 commit into
masterfrom
optimize-iterative-traversal
Dec 12, 2025
Merged

Convert recursive method into iterative to prevent function calls#143
berendkleinhaneveld merged 1 commit into
masterfrom
optimize-iterative-traversal

Conversation

@berendkleinhaneveld

Copy link
Copy Markdown
Collaborator

Just after merging #142 I thought of making this method non-recursive to prevent the overhead of the recursive function call. This should improve the performance a bit more, although not as dramatically as #142.

@berendkleinhaneveld

berendkleinhaneveld commented Dec 12, 2025

Copy link
Copy Markdown
Collaborator Author
------------------------ benchmark 'traverse_deep': 2 tests ------------------------
Name (time in us)                          Mean             StdDev            Rounds
------------------------------------------------------------------------------------
test_traverse_deep (NOW)               899.7457 (1.0)      27.3784 (1.0)         712
test_traverse_deep (0001_master)     1,161.3173 (1.29)     59.9269 (2.19)        593
------------------------------------------------------------------------------------

Not too bad!

@berendkleinhaneveld
berendkleinhaneveld merged commit f58db5a into master Dec 12, 2025
10 checks passed
@berendkleinhaneveld
berendkleinhaneveld deleted the optimize-iterative-traversal branch December 12, 2025 21:29
berendkleinhaneveld added a commit that referenced this pull request Dec 12, 2025
* Improve performance of traverse method (#142, #143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant