Fix saving benchmark results - #28
Merged
Merged
Conversation
Contributor
Author
|
@Korijn I'm curious to hear whether you would be interested in the historical benchmark data? I think it will mostly add a lot of noise to the benchmark output. I'll merge this now but I'm open for discussion. Since this might also make sense to then apply in |
Merged
berendkleinhaneveld
added a commit
that referenced
this pull request
Nov 24, 2025
This version includes: * benchmarks on CI #22 #28 * improved CLI output when dealing with multiple files (more like ruff, although less detailed) #23 * use current working directory as default path argument (like ruff) #29 * major performance improvements * reduce disk access #25 * only sort when needed and cache the setting lookup #26 * batch formatting of template expression in one go #27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub caches are immutable, so saving to a restored cache is not going to work.
Instead, store to a unique key and restore with using a restore key.
Also, clear out old benchmarks while we're at it and only (re)store the latest results.