Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read args only when needed to allow importing the module #50

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

depau
Copy link
Collaborator

@depau depau commented Oct 11, 2017

The arguments should not be read on top-level code, only when the program is executed.

This way other Python code can use the module functions.

@PrabhanshuAttri
Copy link
Collaborator

Thanks @Depaulicious. In future, please make sure that you create an issue before creating a PR. Have you test it for all the functionalities?

@depau
Copy link
Collaborator Author

depau commented Dec 21, 2017

In future, please make sure that you create an issue before creating a PR.

Sounds like a weird way of working to me but no problem.

Have you test it for all the functionalities?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants