Skip to content

Conversation

@redianthus
Copy link
Contributor

This will be used in Owi (or maybe the simplification makes sense directly in Smt.ml, we'll see).

The idea is that, when we add something like symbol_0 = 42 in the PC. Then, we can propagate the equality and replace symbol_0 by 42 in order to simplify the PC and save time/solver calls in the remaining execution.

This is a quick draft, I'll finish it soon.

@redianthus redianthus marked this pull request as ready for review November 19, 2025 17:19
@redianthus redianthus requested a review from a team as a code owner November 19, 2025 17:19
@redianthus
Copy link
Contributor Author

redianthus commented Nov 19, 2025

@filipeom, should be good to review now. It finally decided that the function should take an expression and a map from symbol to expression as input, which is how we'll be using it in Owi. Let me know if you can think of a better API (or naming :-)).

While reading the code around, I also noticed some pattern matching that could be simplified a little bit and decided to commit all of this together, sorry about this 😅

Copy link
Member

@filipeom filipeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filipeom, should be good to review now. It finally decided that the function should take an expression and a map from symbol to expression as input, which is how we'll be using it in Owi. Let me know if you can think of a better API (or naming :-)).

While reading the code around, I also noticed some pattern matching that could be simplified a little bit and decided to commit all of this together, sorry about this 😅

Thanks for taking the time to do this! I had a small question below. Regarding naming, I'm probably the worst person to suggest any change 😅 I actually like the API you're proposing

@redianthus
Copy link
Contributor Author

@filipeom PTAL :)

Copy link
Member

@filipeom filipeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can merge if you want 😄

@redianthus redianthus merged commit 80d77dd into formalsec:main Nov 21, 2025
9 checks passed
@redianthus
Copy link
Contributor Author

Thanks! I merged directly ~~

@filipeom
Copy link
Member

Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants