Skip to content

Conversation

@tiferrei
Copy link
Contributor

Hi there,

Thanks a lot for this project! I just added a parameter for fixing the random seed (for Z3), and thought I'd submit a PR to upstream if anyone else is interested.

I had to remove the %%VERSION%% template from main.ml, as it was giving me compilation issues. AFAIK this seems to not be populated at any point, but I am happy to remove that commit.

Thanks,

Tiago

@tiferrei tiferrei requested a review from a team as a code owner November 19, 2025 21:45
Copy link
Member

@filipeom filipeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much your contribution! Everything looks good to me. Let me know if you have any issues using smtml!

@filipeom filipeom enabled auto-merge (rebase) November 20, 2025 11:41
@filipeom filipeom disabled auto-merge November 20, 2025 11:42
@filipeom filipeom merged commit 990331c into formalsec:main Nov 20, 2025
9 checks passed
@tiferrei
Copy link
Contributor Author

Thanks a lot for getting this merged so quickly!

Now that you mention it, I have had some issues getting the cvc5 lib installed through nix (nix build 'github:tweag/opam-nix#cvc5.latest'), probably something to do with the static libraries and macOS, however this seems to be a Nix specific problem.

Additionally, I noticed that there is no support for tuples or enums, which at first gave me some issues but I was able to work around with lists and some hacky integer representations. Thanks again!

@filipeom
Copy link
Member

filipeom commented Nov 20, 2025 via email

@tiferrei
Copy link
Contributor Author

For enums, we already have the mappings for them in smtml

Ah very nice! No worries, it is not a key feature for me

@filipeom
Copy link
Member

These changes should be included in smtml.0.15.0 if you're interested. Should be available in Opam once ocaml/opam-repository#28957 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants