Refactor exception handling in operator evaluation #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipeom
force-pushed
the
filipe/improve-exception-handling
branch
from
04aae9a to
a1f07f8
Compare
redianthus
reviewed
Nov 21, 2025
filipeom
force-pushed
the
filipe/improve-exception-handling
branch
from
a1f07f8 to
fcd1f8d
Compare
Previously, during operator evaluation we would raise generic failures for following three reasons: - A theory was unsupported - An operator was not supported by a given theory, and - A failure in the evaluation of an operator This would make exception handling difficult for apps that need to gracefully handle failures. For this reason, we refactored the above exceptions to instead raise a `Eval_error` of type `error_kind`. Additionally, the refactor included: - Fixing a couple of bugs when raising the `Type_error` exception. - Adding all the helpers used for value coercion at the top of the file. I think it's more organised this way. Only time will tell. BREAKING: Exception API changed for the `Eval` module
filipeom
force-pushed
the
filipe/improve-exception-handling
branch
from
fcd1f8d to
84d70a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, during operator evaluation we would raise generic failures for following three reasons:
This would make exception handling difficult for apps that need to gracefully handle failures. For this reason, we refactored the above exceptions to instead raise a
Runtime_exceptionof typeruntime_exception_kind.Additionally, the refactor included:
Type_errorexception.BREAKING: Exception API changed for the
Evalmodule