add Expr.split_{conjunctions,disjunctions} #456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful in Owi to make the PC independence algorithm better, for now, a conjunction is forced to be put under the same union-find group, which is unfortunate. Splitting them this way before adding them to the UF should improve things a lot.
I also added
split_disjunctionswhile I was at it, but not sure it'll be useful for now.It may be possible to push the split even further, for instance, if we have$¬(P ∨ Q)$ we could do $\lbrace ¬P ; ¬Q \rbrace $ . But I am not sure yet if this belong to this function or to a simplification, so I left it out for now. I'll experiment with this and see what would be best.
edefined assplit_conjunctions eto be