Add the names of SMT solvers to their mappings (and log them with SMT queries) #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
I feel it's ok to leave them as static strings in the program. Getting them from the command line would be tricky for people who just want to use the library. Also, then the name would also have to be an |
filipeom
approved these changes
Nov 24, 2025
Contributor
Author
|
You're right, it seems to be better to keep it this way then. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding them as hard coded strings to the mappings seemed to be simplest way, but their might be more elegant ways to do it. (by getting it from the command line options maybe?)