Append to the query logging file instead of truncating it. #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipeom
approved these changes
Nov 24, 2025
Member
filipeom
left a comment
filipeom
left a comment
There was a problem hiding this comment.
LGTM! ☑️
On a side node, from what I could see, there are no functions in bos to provide similar behaviour 😬
Contributor
|
Indeed, I opened an issue to see if we can add it. :) I think we can merge this as is for now. |
Contributor
Author
|
Yes, I took a quick look at the API and I didn't see any function to do it.
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Bos.OS.File.writethat was previously used truncates the file then writes to it, which means that if you have multiple runs of smtml, you'd have to reset theQUERY_LOG_PATHto a new path each time if you want to keep all of them (or copy the file every time).The current one simply appends to the file if it already exists,which means that one file can be used for all the queries.
I am not very familiar with
Bosso I am not sure how to get the same behavior using it.